1. Explicity add inputs for is-code logic even though it is not needed for the logic to work. This is to support MPS GUI improvements. (Most is-code logic already had these, just added those that were missing.) 2. Add VMPS_FEE1_E202_NOGAS_THRESHOLD to logic devices--again? Added it in 2015-05-18-a and used it in logic but it still does not appear in device list. This seems not good. 3. Some cleanup/updating of FEE GATT/SATT and SXRSS is-code comments 4. Modify logic fo CXI:SC3:VGC:01 Gate Valve Position Turns out this is not OUT limit switch, but a OK/FAULT status that is provided by a photon-side PLC. That PLC takes in the IN/OUT limit switch bits and calculates its own states. [sonya@lcls-dev2 algorithm]$ sdiff -bs 2015-07-13-a/doc/MPSLogicDocumentation.txt 2015-07-13-b/doc/MPSLogicDocumentation.txt .. title:: MPS Logic 2015-07-13-a | .. title:: MPS Logic 2015-07-13-b CXI:SC3:VGC:01 Gate Valve Position | CXI:SC3:VGC:01 Be Gate Valve Position - Status from PLC ---------------------------------- | ------------------------------------------------------- ======== = ==================== ==================== ======== | ================ = ==================== ==================== ======== = ==================== ==================== ======== | ================ = ==================== ==================== Not Open F 0 Hz 0 Hz | Moving or Broken F 0 Hz 0 Hz Open T 120 Hz 120 Hz | Open or Closed T 120 Hz 120 Hz ======== = ==================== ==================== ======== | ================ = ==================== ==================== * pressure is above a specified threshold | * pressure is above a specified threshold, * and any solid attenuators are NOT OUT | * the gas valve is NOT CLOSED, > * AND any solid attenuators are NOT OUT * Gas pressure OK/Fault input comes from FEE PLC | * Gas pressure and valve status summary OK/Fault input c state = 0; /* Gas attenuator interlock is OK (pressu | state = 0; /* Gas attenuator interlock is OK (pressu state = 2; /* Not all solid attenuators are OUT, not | state = 2; /* Not all solid attenuators are OUT, NOT * e- beam position 14.0 < x | * e- beam position OK [mm] * e- beam energy 3.35 < E | * e- beam energy OK [GeV] * <=7 upstream undulators I | * upstream undulators IN OK * e- beam position -1 < | * e- beam position OK [ * e- beam position 2.5 < x | * e- beam position OK [mm * e- beam energy 11 < E | * e- beam energy OK